search

NYPL / staff-picks

1 stars 3 forks source link

Year month and selector changes #206

Closed gkallenberg closed 6 years ago

gkallenberg commented 6 years ago

These help to resolve issues #200 and #201. #200 is a simple lable change for the annual lists for Sidebar dropdowns. Should display 'Year' instead of 'Season.'

Changes for issue #201 requires coordination in updating the metadata for lists on the ingester side. Once the year-month pattern for lists is available in the API, the direct links and redirects should work.

To test, start your local instance using APP_ENV=production. The new pattern is deployed there for staff-picks lists. There are 2 lists there that you can use to test the code changes within this PR.

ktp242 commented 6 years ago

Let's update the data model fortest/unit/ListFilter.test.js and test/unit/ListSelector.test.js too.

EdwinGuzman commented 6 years ago

I keep being redirected to the 404 page when going to /best-books/staff-picks:

Status Code: undefined, Error Message: undefined and Type '404' not found in selectData

ktp242 commented 6 years ago

When I tried visit http://local.nypl.org:3001/books-music-movies/recommendations/best-books/staff-picks/2018-03-01, I got the error "message":"Status Code: 404, Error Message: staff-picks/2018-03 not found"

I ran this on my terminal APP_ENV=production KMS_ENV=unencrypted node index