NYU-DevOps-Charlie-CSCI-GA-3033-013 / products

Product Team for CSCI-GA.3033-013
http://nyu-lab-bluemix-charlie-products.mybluemix.net/
1 stars 1 forks source link

added bdd for listing products #41

Closed vignesh3193 closed 7 years ago

vignesh3193 commented 7 years ago

BDD for listing products working added a data_load function in server to send some data to redis corrected spelling of initialize_redis() function

ephraimrosenfeld commented 7 years ago

@vignesh3193 , you need to add the dependencies to the requirements.txt file:

# BDD
behave==1.2.5
selenium==3.3.1

This is the reason the build failed on Travis CI.

ephraimrosenfeld commented 7 years ago

When I run the behave test locally (after including the dependencies in the requirements.txt file) I get some test failure issue that it cannot read the price attributes from the Feature file.

vignesh3193 commented 7 years ago

The ID is given by the system so it doesn't really matter but I will change it. The tests were working correctly on my machine. I will take a look. Apologies about the requirements file, I'm really not sure how to use travis.

codecov[bot] commented 7 years ago

Codecov Report

Merging #41 into master will decrease coverage by 1.06%. The diff coverage is 15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   23.07%   22.01%   -1.07%     
==========================================
  Files           1        1              
  Lines         143      159      +16     
==========================================
+ Hits           33       35       +2     
- Misses        110      124      +14
Impacted Files Coverage Δ
server.py 22.01% <15%> (-1.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbba14f...8bbdef3. Read the comment docs.

ephraimrosenfeld commented 7 years ago

I made changes to the BDD branch. What I believe was happening is that, on your local/dev environment you've set the newkey value in your db as a result of running the server web application - but this value never gets set when running TDD/BDD tests. This explains why the tests were failing on Travis - which only runs the unit and integration tests. The change is set this value in TDD/BDD tests as well.