An error in calculating MAPE for QoR tasks

NYU-MLDA / OpenABC

OpenABC-D is a large-scale labeled dataset generated by synthesizing open source hardware IPs. This dataset can be used for various graph level prediction problems in chip design.

BSD 3-Clause "New" or "Revised" License

113 stars 19 forks source link

An error in calculating MAPE for QoR tasks #14

Open Jedges opened 2 months ago

Jedges commented 2 months ago

/models/qor/SynthNetV1/utils.py line 258，When calling mean_absolute_percentage_error for calculation, are the two parameters placed in reverse order? The first one in the function description is y_true, and the second one is y_pred, but the code uses y_pre as the first parameter. I am not sure if my understanding is wrong, please let me know if I am wrong

animeshbchowdhury commented 2 months ago

Indeed, you pointed out an error. I did calculate the MAPE score incorrectly. It should have been reversed.

Can you make a PR with the change?

Jedges commented 2 months ago

Yes, I maked a PR with the change. But I'm not sure if I'm doing the PR operation correctly, this is my first time using it.