search

NYU-Processor-Design / nyu-amba

NYU Processor Design Team's interpretation of ARM's AMBA specifications.
Creative Commons Zero v1.0 Universal
1 stars 6 forks source link

Test bench attempt #26

Closed Auryny268 closed 1 month ago

Auryny268 commented 2 months ago

I sat down with Vito this time and wrote the manager. I also wrote the test bench, but I still haven't tested it yet (gotta read up on cmake in the morning). I wanted to commit my changes tonight just so I have something to show for my work!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.52%. Comparing base (fabbe2d) to head (df8a59c).

:exclamation: Current head df8a59c differs from pull request most recent head 8dc985f. Consider uploading reports for the commit 8dc985f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #26 +/- ## ======================================= Coverage 70.52% 70.52% ======================================= Files 3 3 Lines 95 95 ======================================= Hits 67 67 Misses 28 28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rishyak commented 2 months ago

Good job so far. You have one failed test and one test that infinitely loops. I'll merge it when you fix that.

EDIT: Fixed the loop variable @Auryny268

rishyak commented 1 month ago

Closing this because #28 includes these commits