NYU-Processor-Design / nyu-core

The code and tests for the RISCV-32I compatible core for the NYU Processor Design VIP team.
Creative Commons Zero v1.0 Universal
2 stars 12 forks source link

Add Branch Address Calculator #107

Closed gil92723 closed 10 months ago

ShinyMiraidon commented 10 months ago

You appear to have errors in your verilog module

codecov[bot] commented 10 months ago

Codecov Report

Merging #107 (60c4b43) into main (8f924fa) will increase coverage by 0.18%. Report is 62 commits behind head on main. The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   94.78%   94.96%   +0.18%     
==========================================
  Files           7        8       +1     
  Lines         115      139      +24     
==========================================
+ Hits          109      132      +23     
- Misses          6        7       +1     
Files Coverage Δ
rtl/Branch_Addr_Calc.sv 95.83% <95.83%> (ø)
ShinyMiraidon commented 10 months ago

So the test passes but the codecov errors indicate there is some code you added that isn't getting tested. I'd look into the details provided to see what exactly is going wrong