NYU-Processor-Design / nyu-core

The code and tests for the RISCV-32I compatible core for the NYU Processor Design VIP team.
Creative Commons Zero v1.0 Universal
2 stars 11 forks source link

docs(Con_Branch_cont): dev test not finish, maybe wrong #138

Closed xingzhi0420 closed 8 months ago

ShinyMiraidon commented 9 months ago

A few things:

  1. This PR should have the add heading or connection_module heading not the docs heading as you added files for a connection module, the docs heading is for updating documentation files.

  2. Your tests are failing because you added your module file name to the end of the CMake file in the dv folder, it needs to go before any modules it contains

ShinyMiraidon commented 8 months ago

You should also make sure to name your tests different things than what the tests are called for the base modules, otherwise you will get an error