NYU-Processor-Design / nyu-core

The code and tests for the RISCV-32I compatible core for the NYU Processor Design VIP team.
Creative Commons Zero v1.0 Universal
2 stars 12 forks source link

refactor: Formatting and syntax fixes #147

Closed nickelpro closed 5 months ago

nickelpro commented 5 months ago

This PR is a courtesy because it will break outstanding work that will need to be rebased. This will merge in a day or two if there's no other issues.

Build:

Style:

Function:

Refactor:

codecov[bot] commented 5 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e74b8c0) 97.86% compared to head (44066ae) 98.18%.

Files Patch % Lines
rtl/Branch_Predictor.sv 87.50% 2 Missing :warning:
rtl/IDEX.sv 95.65% 1 Missing :warning:
rtl/Pipeline_Reset.sv 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #147 +/- ## ========================================== + Coverage 97.86% 98.18% +0.32% ========================================== Files 13 13 Lines 234 276 +42 ========================================== + Hits 229 271 +42 Misses 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nickelpro commented 5 months ago

Also coverage is completely broken because of a bug in the way tests are done, that fix is coming in a separate PR