search

NYU-Processor-Design / nyu-core

The code and tests for the RISCV-32I compatible core for the NYU Processor Design VIP team.
Creative Commons Zero v1.0 Universal
2 stars 12 forks source link

Revert "refactor: Formatting and syntax fixes" #150

Closed ShinyMiraidon closed 5 months ago

ShinyMiraidon commented 5 months ago

Reverts NYU-Processor-Design/nyu-core#147

nickelpro commented 5 months ago

In the future, if something goes screwy with a fast-forward or other merge and you notice immediately, don't do a revert commit. It just further pollutes the history.

The "correct" thing to do (keeping in mind that git practices are very, very subjective) is to git reset to the earlier commit and then force upstream back to that commit.

If the commit is weeks old, or other commits are on top of it already, a revert might be appropriate.