search

NYULibraries / primo-explore-views

A consolidated monorepo of NYU Consortium views
MIT License
2 stars 1 forks source link

Add trivial test for "Add to Saved Items" checkbox #377

Open ericgriffis opened 2 years ago

ericgriffis commented 2 years ago

Add a test – preferrably unit test but, if not possible, an e2e test – that checks for the correct aria-label value on the "Add to Saved Items" checkbox. This is a configured value in a custom npm package. We'd like to add a simple test as a "sanity check" that this package loads and configures properly.

da70 commented 2 years ago

@ericgriffis Great idea. Since we prefer unit test, should I move this ticket to primo-explore-nyu-eshelf (the karma unit tests are there)?

We could add an e2e test to monorepo too if we want a sanity check at integration level.

da70 commented 2 years ago

Disregard my previous comment -- I hadn't realized there were unit tests in the monorepo as well: primo-explore-views/custom/spec/.