search

NYULibraries / primo-explore-views

A consolidated monorepo of NYU Consortium views
MIT License
2 stars 1 forks source link

Run tests against anticipated Angular 1.8 enabled Primo version using `testAngularCompatibility=true` query param #380

Open da70 opened 2 years ago

da70 commented 2 years ago

Preparing for the Upgrade to Angular 1.8 in Primo/Primo VE

GitHub: 380_run-tests-against-anticipated-angular-1-8-enabled-primo-version

CircleCI: 380_run-tests-against-anticipated-angular-1-8-enabled-primo-version

References

da70 commented 2 years ago

cy.visit has a qs option for adding query parameters.

Might be able to use `cy.intercept to automatically add the query param to all requests. EDIT: Doesn't look like cy.intercept is global. Just going to do it manually instead using qs option.

da70 commented 2 years ago

CircleCI test run in progress: https://app.circleci.com/pipelines/github/NYULibraries/primo-explore-views/1118/workflows/0cd688cf-59db-4f3c-9c8c-cfedef3404ac

EDIT: Some tests failed, but in a subsequent run of the same commit, they all passed: https://app.circleci.com/pipelines/github/NYULibraries/primo-explore-views/1118/workflows/5d9bab73-41a5-4b6f-baaa-38bd0b731e1d

da70 commented 2 years ago

Refreshed from development: all pass

Refreshed from development a couple months ago, all pass: https://app.circleci.com/pipelines/github/NYULibraries/primo-explore-views/1125/workflows/8beb15ca-4db4-4245-bcc3-7c4236a5b3db

da70 commented 2 years ago

Refreshed from development

Three runs on the same commit all failed:

https://app.circleci.com/pipelines/github/NYULibraries/primo-explore-views/1182/workflows/a2a6abab-269c-4638-9236-e57282aa7c79 https://app.circleci.com/pipelines/github/NYULibraries/primo-explore-views/1182/workflows/8103b09b-2381-435b-9584-6ddd385d7fef https://app.circleci.com/pipelines/github/NYULibraries/primo-explore-views/1182/workflows/d825d94d-6a2c-42ce-8a22-7d7b36ad51e3