feature/add support for 2022 migration yml with override

NYULibraries / specialcollections

NYU Libraries Special Collections Discovery Application

https://specialcollections.library.nyu.edu

MIT License

8 stars 4 forks source link

feature/add support for 2022 migration yml with override #258

Closed jgpawletko closed 1 year ago

jgpawletko commented 1 year ago

Overview:

This PR adds support for using different values from repositories.yml file based on the presence of the ENV['FINDINGAIDS_2022_MIGRATION'] variable.

This change is needed because the subdirectory name for the Center for Brooklyn History has changed from bhs to cbh in the FINDINGAIDS_2022_MIGRATION EAD Git repository.

jgpawletko commented 1 year ago

Hi @ericgriffis ,

I know that you are super-busy, but if you get a chance, I'd love your feedback on the changes in this PR.

The most significant change is here.

Also, if you know of a better way to force a class-definition reload in an RSpec example than what I implemented here, I would love to learn about it.

Thank you for your time! Best- Joe