search

NYULibraries / specialcollections

NYU Libraries Special Collections Discovery Application
https://specialcollections.library.nyu.edu
MIT License
8 stars 4 forks source link

Feature/change display order #46

Closed eshadatta closed 9 years ago

eshadatta commented 9 years ago

@barnabyalter @NYULibraries/finding-aids ,

I'm creating a PR for brief history display for collection result and brief history non-collection. I have a rspec test that 's failing because I get an error

Failures:

1) Findingaids::Ead::Component#to_solr #heading Failure/Error: let(:solr_doc) { document.to_solr } NoMethodError: undefined method `length' for nil:NilClass

./lib/findingaids/ead/behaviors/component.rb:26:in`title_for_heading'

 # ./lib/findingaids/ead/behaviors/component.rb:41:in `bread_crumb'
 # ./lib/findingaids/ead/component.rb:68:in`to_solr'
 # ./spec/lib/findingaids/ead/component_spec.rb:184:in `block (4 levels) in <top (required)>'
 # ./spec/lib/findingaids/ead/component_spec.rb:185:in`block (4 levels) in <top (required)>'
 # ./spec/lib/findingaids/ead/component_spec.rb:186:in `block (4 levels) in <top (required)>'

Finished in 13.74 seconds 235 examples, 1 failure

I had added a new field "breadcrumb" to solr, so that I could easily parse and generate the "contained in" navigation trail and rspec is having issues with that. The code does work, so I'm not quite sure where to go from here. I had tried adding a breadcrumb field and I was still getting an error. I am still working to see if I can get it fixed, but I thought I would ask you to see if you could help me find the problem. Thanks so much. I still need to add other rspec and cucumber tests to this. Thanks in advance.

Esha

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.86%) to 95.27% when pulling f42e150a2129dbe24d93498c9b2836db4630b166 on feature/change_display_order into 8bdc8be6668799c9dc2801f0553f3708cd10379b on development.

barnabyalter commented 9 years ago

@eshadatta It looks like you deleted the branch so I can't take a look. I assume you're making additional changes. If you want someone to take a look please push changes back and drop a line. Tx

eshadatta commented 9 years ago

Hi,

Yes, I figured out that problem and so deleted that branch and am in the process of making additional changes. Thanks for taking the time though, I really appreciate it.

Esha

On Fri, Mar 13, 2015 at 5:05 PM, barnabyalter notifications@github.com wrote:

@eshadatta https://github.com/eshadatta It looks like you deleted the branch so I can't take a look. I assume you're making additional changes. If you want someone to take a look please push changes back and drop a line. Tx

— Reply to this email directly or view it on GitHub https://github.com/NYULibraries/findingaids/pull/46#issuecomment-79397144 .