Feature/stable repo links - Githubissues

NYULibraries / specialcollections

NYU Libraries Special Collections Discovery Application

https://specialcollections.library.nyu.edu

MIT License

8 stars 4 forks source link

Feature/stable repo links #56

Closed chrpr closed 9 years ago

chrpr commented 9 years ago

@barnabyalter @NYULibraries/finding-aids

Hi All,

This replaces closed PR #48. I've backed out changes to coffeescript and routes for dropdown selection that were deemed unnecessary following our last sprint planning meeting. I also re-wrote a few of the tests and rebased on the current development branch.

Let me know if there's anything else you'd like to see addressed here.

-Corey

coveralls commented 9 years ago

Coverage increased (+0.3%) to 97.65% when pulling 344554563ca53fbce114763ddbebc73dedd18a7c on feature/stable_repo_links into e3b6e9ea13b2614cee637b3bcb95d630f6220172 on development.

coveralls commented 9 years ago

Coverage increased (+0.3%) to 97.65% when pulling 344554563ca53fbce114763ddbebc73dedd18a7c on feature/stable_repo_links into e3b6e9ea13b2614cee637b3bcb95d630f6220172 on development.

chrpr commented 9 years ago

@barnabyalter Just pushed 3 new commits, that I think address your remaining comments. Let me know if there's anything else you'd like out of me on this.

coveralls commented 9 years ago

Coverage increased (+0.3%) to 97.65% when pulling cfe3271173d70e8c2ab3347aa97e93041cb97588 on feature/stable_repo_links into e3b6e9ea13b2614cee637b3bcb95d630f6220172 on development.

coveralls commented 9 years ago

Coverage increased (+0.3%) to 97.65% when pulling efbc21c1e1d89689db2966d10bdb2d2bb758779a on feature/stable_repo_links into e3b6e9ea13b2614cee637b3bcb95d630f6220172 on development.

coveralls commented 9 years ago

Coverage increased (+0.3%) to 97.65% when pulling efbc21c1e1d89689db2966d10bdb2d2bb758779a on feature/stable_repo_links into e3b6e9ea13b2614cee637b3bcb95d630f6220172 on development.