search

NYUMusEdLab / notio

Notio - A music theory learning React App that runs in the browser
https://nyumusedlab.github.io/notio/
Creative Commons Attribution Share Alike 4.0 International
1 stars 0 forks source link

ColorKey, has a classname component that allows us to display whether the tone is C? #228

Closed saxjax closed 1 year ago

saxjax commented 1 year ago

Is there a theoretical reason for showing the C to the user or is it more relevant to show the Root? in ColorKey

//TODO:Do we want this to show whether the tone is C or whether it is the Root in the scale
          (note.includes("C") && !note.includes("#") && !note.includes("b")) || note.includes("B#")
            ? "" /*"c-mark"*/
            : ""
ceciliabjork commented 1 year ago

@saxjax At some point we have a thought that because it is not always easy to identify the pattern of 2 + 3 black keys, we could have a small indicator for C. But this is maybe not necessary.

saxjax commented 1 year ago

implemented in

https://github.com/NYUMusEdLab/notio/pull/267