NYUMusEdLab / notio

Notio - A music theory learning React App that runs in the browser
https://nyumusedlab.github.io/notio/
Creative Commons Attribution Share Alike 4.0 International
1 stars 0 forks source link

Upgrade the share functionality #253

Open ceciliabjork opened 1 year ago

saxjax commented 1 year ago

Remove the save new setup button, make sure that the setup is saved when share button is clicked

saxjax commented 1 year ago

Before removing consider this: A user sets up some setting. then user clicks share this setup. discovers that there is an error in the setup. makes changes to the setup. then clicks share this setup again. What sould happen?

  1. User is presnted with a new link to astorred version of the recently created changes. Previous link is gone.
  2. User is presented with link to currently stored setup, a button lets user generate a new link to store the recent changes on.

I think the propper way to do this is to change the wording of the button to "save current settings on new url"

ceciliabjork commented 1 year ago

@saxjax @MartinBruun @granfors Usually the Share icon leads to more options, and I believe that was what Muriel had in mind. At the moment, I think a single function (copy) would be the least confusing. Just the link and the text "Copy link" at the moment. (And it would be great to have buttons for other Share functions later! See example from Twitter below...) Yes, the user would have to keep a manual record of iterations, but at the moment, I would be more inclined to go for as simple and immediately understandable as possible. IMG_8116

MartinBruun commented 1 year ago

So far fixed by:

288

ceciliabjork commented 1 year ago

@MartinBruun @saxjax It is still not at all clear to me what the "store online" means... Would it be possible to make this super simple and super clear just for the presentation? Just a "Copy link"? If someone asked me what the current configuration is for and how the different tabs works, I wouldn't be able to answer.

MartinBruun commented 1 year ago

@ceciliabjork Ahh yes I see what you mean, i closed it too quickly. Will change it Tommorow morning. For some reason I overlooked that.