search

NYUMusEdLab / notio

Notio - A music theory learning React App that runs in the browser
https://nyumusedlab.github.io/notio/
Creative Commons Attribution Share Alike 4.0 International
1 stars 0 forks source link

Multisound #281

Closed saxjax closed 1 year ago

saxjax commented 1 year ago

selectable sound library, but can't release sound

saxjax commented 1 year ago

undersøg react-native-soundfont-player https://www.npmjs.com/package/react-native-soundfont

check nogle af disse ud også: https://www.npmjs.com/search?q=soundfont

MartinBruun commented 1 year ago

Looks and sounds super cool! I'm creating a seperate PR to merge into this one, that will fix the tests (i think i know what it is) and also, i think this presentation here could look sharper: image

Ie. "acoustic_grand_piano" should be "Grand Piano" and "electric_grand_piano" should be "Electric Piano" (it goes out over the sides when its chosen, and the underscore casing looks wrong)

If you disagree, please write to me immidiately :)