NYUMusEdLab / notio

Notio - A music theory learning React App that runs in the browser
https://nyumusedlab.github.io/notio/
Creative Commons Attribution Share Alike 4.0 International
1 stars 0 forks source link

Create a unified keyboardSettings object #286

Open MartinBruun opened 1 year ago

MartinBruun commented 1 year ago

Create a class that encompasses all the settings in the topmenu and makes getting and setting the values streamlined.

Whether this is done through a props system (so the same keyboardSettings instance is passed down) or a Provider/Context is not the important part. What is important is that everything that has domain logic (ie. everything Non-UI specific / design) should be combined into one singular class that takes all of the logic regarding music theory out of the React presentation.

This is necessary because alot of calculations happen at different areas. A general overhaul of describing the different modules in Notio would also help maintenance to follow a better folder structure.