search

NZME / react-native-ad-manager

Google Ad Manager bridge for React Native
MIT License
50 stars 62 forks source link

Support for Turbo Modules #128

Open dcisneros2 opened 1 month ago

dcisneros2 commented 1 month ago

Hello Dev Team, is turbo module support being planned for this SDK? We've updated to latest and seems it does not have any support at this point.

jazdance commented 1 month ago

hi there, thanks for the feedback, due to priority, not this moment, but I'll raise it in our team discussion next week, hopefully will find time to look into it after June.

dcisneros2 commented 1 month ago

hi there, thanks for the feedback, due to priority, not this moment, but I'll raise it in our team discussion next week, hopefully will find time to look into it after June.

Thank you for the reply. In the meantime, we are trying to add it this SDK to our interop list.

We've tried these packages below but so far cannot get this SDK to work with our turbo modules build. Do you know exactly what we should be adding since you would be more familiar with the SDK?

We are adding to: unstable_reactLegacyComponentNames

Tried these so far: 'CTKAdManageNativeManager', 'CTKAdManageNative', 'CTKAdaptiveBannerView', 'CTKBannerView', 'CTKAdaptiveBannerView', 'CTKInterstitial', 'CTKAdaptiveBannerViewManager', 'CTKBannerViewManager'

chriszs commented 1 week ago

I believe newer versions of the Interop Layer don't require listing the components, and may require less work for React Native Ad Manager to support than a full TurboModules conversion. Which isn't to say TurboModules isn't a good bet in the long term, or that every project's going to support the latest Interop Layer just yet (some are likely stuck on older versions of React Native), but just that it may be possible to support New Arch on the latest versions of React Native with a much lower level of effort on the part of NZME.

chriszs commented 1 week ago

Related to #111