Add & configure sentry-raven

NZOI / nztrain

The NZOI online judge and training site written in Ruby

18 stars 13 forks source link

Add & configure sentry-raven #221

Closed bagedevimo closed 10 months ago

bagedevimo commented 10 months ago

Use the Settings table to store the DSN to prevent it leaking to the entire world via the source code. Once we have better env or secret management we should migrate to that.

bagedevimo commented 10 months ago

Current dependencies on/for this PR:

master
- PR #198
- PR #199
  - PR #221 👈
  - PR #200

This stack of pull requests is managed by Graphite.

tom93 commented 10 months ago

I'm not familiar with sentry-raven, but from the docs it sounds like it has been replaced with sentry-ruby...

bagedevimo commented 10 months ago

You're 100% correct, but sentry-ruby / sentry-rails require more modern versions of both ruby & rails, and it'd be really nice to have to error reporting while we upgrade to those versions.

tom93 commented 10 months ago

Aside: Just noticed we already have the gem because qless depends on it. Update: But gone in #224.

tom93 commented 10 months ago

@bagedevimo I rebased and force-pushed due to Gemfile.lock conflict with #224. Bundler ended up picking sentry-raven 3.1.2 instead of 0.15.6. I also modified the comment to mention the native SENTRY_DSN env var.