NZSmartie / PyHIDParser

A HID descriptor parser written in Python 3
MIT License
23 stars 5 forks source link

Improve Device class (Collections) structure #9

Open NZSmartie opened 8 years ago

NZSmartie commented 8 years ago

I'm concerned with the ambiguity and readability with accessing Collections or Reports in a Device Class or more accurately the Collection class.

As is the case with examples/dual-shock-3.py there are logical collections nested under the root Joystick collection that are not assigned a Usage. Resulting in code that looks like this

buttons = my_device.desc.reports[1].inputs.joystick[0][1]

To break it down:

At the moment, i'm not too sure how to make it more readable, will comment on this later