NaSTAuk / graphics

A repository for HTML based, TV Graphics
MIT License
3 stars 2 forks source link

Should we assume CEF3? #13

Open benjaminkay93 opened 5 years ago

benjaminkay93 commented 5 years ago

It appears that CasparCG supports at least CEF3239 Chromium 63 (see https://github.com/CasparCG/server/pull/724) as of 29 December 2018.

Should we assume going forward that we won't support less than this? I can imagine a world where graphics packages won't necessarily support something so up to date, but we could end up in a world where we have very limited CSS options if we don't draw a line modern enough.

niklasR commented 5 years ago

Has this been tested/confirmed by someone here? I'd like to be able to say yes, CEF3 with 3d transforms and whatnot 👍, but it would be nice to have it tested by someone in Caspar, rendered out on a decklink or so.

Could use a suite like http://tests.caniuse.com/ to define what a stable Caspar 2.2 supports out the box and fix to that?

I do not have the capability to do that.

benjaminkay93 commented 5 years ago

That's a cool link, some tooling to valid our usage would be great to have too! Chromium 63 doesnt support gyroscopes though 😞 image

It would nice to have some internal validation for CEF 3 before locking into it. I don't have the necessary things either, @thomasslee97 or @m3lnic, any chance of testing the CEF Version on CasparCG at either of your stations? I can like to an HTML file that would make it clear if it works ;P (@moschopsuk you get one guess)

benjaminkay93 commented 5 years ago

https://github.com/LA1TV/Roses-CasparCG-Graphics/blob/master/public/perspective/field_view.html

Is a file to run to see if CEF 3 works 😄

Vitupero commented 5 years ago

I would assume that this works if it's been merged, but given that Julian (Ex-Guild TV) wrote the PR, I'll ask him!

benjaminkay93 commented 5 years ago

Yeah, we should be relatively safe. It's probably best to just validate our assumptions, even if that is going to the person who implemented it :')

eol-account commented 5 years ago

Yup, current stable CasparCG is CEF3 :)

image

eol-account commented 5 years ago

Result of gyroscope test: negative image

benjaminkay93 commented 5 years ago

Well, that looks beautiful :O

Such a shame about the Gyro though, imagine all the possibilities, we could have known the orientation of a server in any rack... spoiler alert, it is probably horizontal, but it would be nice to have that data!

benjaminkay93 commented 5 years ago

Thanks for that @thomasslee97 😄 🚀

moschopsuk commented 5 years ago

Yup, current stable CasparCG is CEF3 :)

image

Looks like some of the textures are not rendering correctly ?

benjaminkay93 commented 5 years ago

maybe the image texture doesn't exsist anymore?

eol-account commented 5 years ago

This looks to be the missing texture, I'll give it another go at some point + see if there's something obvious I've done wrong.

http://i.imgur.com/bh9ahq3.png

eol-account commented 5 years ago

Yeah the playing field texture wasn't loading from Imgur (tested on Chrome and Firefox). I've stuck it in the /images directory and loaded it from there. Works in CasparCG now!

image

moschopsuk commented 5 years ago

Nice work @thomasslee97!