foobar2000 crashes when Discord is not launched.

Naamloos / foo_discord

Adds the ability for foobar2000 to interact with Discord rich presences.

BSD 2-Clause "Simplified" License

142 stars 9 forks source link

foobar2000 crashes when Discord is not launched. #3

Closed ghost closed 6 years ago

ghost commented 6 years ago

Basically the title. Every time you launch foobar, it'll always crash unless the Discord client is open before foobar. I don't always leave Discord running. I've attached a crash log, they're pretty much identical to one another each time I launch foobar. failure_00000010.txt

Naamloos commented 6 years ago

Ah, I think I can resolve this issue.

I'll look into it tomorrow. Thanks for reporting!

Naamloos commented 6 years ago

I can't seem to replicate this bug. The addon seems to just work when my discord isn't running.

Can you try:

Updating to the latest stable release of foobar2000
Try the newest release of the addon

Newest release is found here: https://github.com/NaamloosDT/foo_discord/releases/tag/1.7

Please report back when possible c:

Naamloos commented 6 years ago

Also, which OS are you running?

Naamloos commented 6 years ago

nvm, that info is in the crash logs

ghost commented 6 years ago

I can no longer replicate the crash with the newest revision. However now, it seems the playback info is incorrect now. This fixes itself after pausing multiple times though.

When playback is stopped upon launching

When playing

After pausing and playing one more time, playback state is corrected.

Edit: Discord also does not recognize rich presence if I start Discord after starting Foobar (though I think this issue relies on discord itself, since this happens with many other rich presence-enabled apps and games too, yet not all). Naturally, this is resolved by restarting foobar.

ghost commented 6 years ago

Update: having crashes again. This seems to only happen under the following conditions:

Save playback state upon closing Foobar is enabled
Foobar is currently playing a track
Either by closing foobar, or having your system restart

It ends up crashing continuously until I remove the plugin. I do hear a bit of the song playback when Foobar launches, only for it to crash a brief moment later. failure_00000012.txt

Naamloos commented 6 years ago

THe playback info being incorrect is likely because discord doesn't update presences right away. It should fix itself after a couple of secs anyway. As for the other bug, I'll have to investigate some more

Naamloos commented 6 years ago

@Reboot80 are you saving playback state via a different component?

Naamloos commented 6 years ago

nvm, I'll check it out. I might know something

Naamloos commented 6 years ago

Yesh, I was able to reproduce the bug. I'll get to work right now.

Naamloos commented 6 years ago

All right. Latest release should fix it. https://github.com/NaamloosDT/foo_discord/releases/tag/1.8 @Reboot80

ghost commented 6 years ago

I no longer have this issue. Thanks for helping me out.