search

NablaZeroLabs / mxd

Space Mission Design Support Tools
MIT License
4 stars 4 forks source link

Implement Shader Class #10

Closed fayalalebrun closed 5 years ago

fayalalebrun commented 5 years ago

I have made the shader class store it's own ID, which is obtained openGL. The type of shader is decided by the Stage parameter given to the class. An attempt is made to compile the shader, and an exception is thrown if this fails. The OpenGL shader object is deleted in the object's destructor. My next step is to implement Google test for this class.

fayalalebrun commented 5 years ago

I made these changes yesterday, before I read the PR guidelines. Is this a good PR size or is it too large? How large should changes be in a PR at the most?