NabuCasa / matter-example-apps

Easily allow users to install Matter example apps from the web.
https://nabucasa.github.io/matter-example-apps/
5 stars 6 forks source link

Remove UniqueId from Basic Cluster #29

Closed agners closed 11 months ago

agners commented 1 year ago

Most real devices do not return a Unique ID. Return an empty string in our example app as well.

agners commented 1 year ago

It seems that the implementation in C++ is currently non optional (there is no compile time option it seems): https://github.com/project-chip/connectedhomeip/blob/v1.0.0.2/src/app/clusters/basic-information/basic-information.cpp#L255-L269

By default, the platform implementation reads the Unique Id from configuration, it seems: https://github.com/project-chip/connectedhomeip/blob/v1.0.0.2/src/include/platform/internal/GenericConfigurationManagerImpl.ipp#L499-L512

I'd have to dig into how this is implemented for ESP.