search

NabuCasa / silabs-firmware-builder

Silicon Labs firmware builder
42 stars 54 forks source link

Use absolute paths for `slc generate` to work around SLC bug #29

Closed puddly closed 11 months ago

puddly commented 11 months ago

Fixes #27.

(Currently untested)

darkxst commented 11 months ago

a posted in the other PR, I think its better to patch the slc launcher. This has been tested!

https://github.com/darkxst/silabs-firmware-builder/commit/a2dcffbd0b32fba6276ce61d1e93949730d2e246

agners commented 11 months ago

a posted in the other PR, I think its better to patch the slc launcher. This has been tested!

darkxst@a2dcffb

Hm, I kinda like this fix as we don't have to revert later on :smile:

Next time we touch this part we can still revert back to relative path, if we wish so.

darkxst commented 11 months ago

I though it was nice to keep the container compatible with past behaviour, but then I guess are probably very few if any people using the container for other builds!

agners commented 11 months ago

I though it was nice to keep the container compatible with past behaviour, but then I guess are probably very few if any people using the container for other builds!

Good argument.

FWIW, I realized that the build without fix actually run through. So maybe the SLC CLI version on SiLabs servers is already fixed?

https://github.com/NabuCasa/silabs-firmware-builder/actions/runs/5712477875

I only realized after merging this already :sweat:

darkxst commented 11 months ago

So maybe the SLC CLI version on SiLabs servers is already fixed?

Yes it has been fixed already with the latest download.