NabuCasa / silabs-firmware-builder

Silicon Labs firmware builder
42 stars 54 forks source link

Optimize container image size #32

Closed agners closed 11 months ago

agners commented 11 months ago

Remove the SDK's git database to optimize the image size. There is no need for the git history (the checkout is anyway shallow).

darkxst commented 11 months ago

wont this break the lfs files? there are a lot of static libs in there, but dont know if any of those are used in the build? If not its probably ok.

agners commented 11 months ago

wont this break the lfs files? there are a lot of static libs in there, but dont know if any of those are used in the build? If not its probably ok.

Why do you think so? We don't delete those, they are checked out (as a copy) at that time (git clone takes care of LFS via filters if LFS support is installed, and LFS is installed in the container).

darkxst commented 11 months ago

Don't worry, I am just probably confusing how lfs works server side vs client side...