search

NachoSoto / NSBKeyframeAnimation

jQuery-like animations in CoreAnimation
MIT License
370 stars 47 forks source link

Fixes issue where layer model wasn't being updated in NSBFunctionView #7

Closed sampage closed 10 years ago

sampage commented 10 years ago

Hey Nacho,

I spotted this just after we had the discussion over at https://gist.github.com/d-ronnqvist/11266321 about removedOnCompletion. I believe this fixes the issue where the layer model remains unchanged despite the animation.

I wasn't sure whether to send this pull request as it looks like this code is no longer maintained and I don't want to come across as a jerk, just wanted to help spread (what I now know is) the correct way :)

Cheers.

Sam.

NachoSoto commented 10 years ago

Hey thank you for the pull request! I wrote this so long ago that I don't remember if I had a reason for this (I can only think that the "all animations" option may have something to do this with it) or simply that at that time I was still following this bad practice :) In any case this is a better implementation, so thanks!