search

Nachtzuster / BirdNET-Pi

A realtime acoustic bird classification system for the Raspberry Pi 5, 4B 3B+ 0W2 and more. Built on the TFLite version of BirdNET.
https://birdnetpi.com
Other
133 stars 20 forks source link

Feat : Add site_info to the title of the species accessed through Recordings or Unique species #113

Closed alexbelgium closed 3 months ago

alexbelgium commented 3 months ago

Currently, the play.php page accessed through Recordings or Today species only shows as a text the common name of the specie

This PR takes advantage of the new site_info function to add a ebird/allaboutbirds link to the title, allowing a faster access and a bit more harmonized management with other pages

alexbelgium commented 3 months ago

It works by adding a new common function (get_sci_name) which does the invert of (get_com_en_name) and then passes it to the (info_site) function. Although it adds a new common function, this seems in line with how the app is coded currently

alexbelgium commented 3 months ago

Reverted to draft, there is an issue in my get_sci_name function

alexbelgium commented 3 months ago

It is now working

Nachtzuster commented 3 months ago

@alexbelgium it is hard to keep up with you :smile: I'll have a look this WE!

alexbelgium commented 3 months ago

Thanks very much! This PR is more a prelude to the one with the icons as it just adds the code that you had written to had ebirds/all about birds. Then the other PR takes it one step further by implementing the logic of icons instead of text. I might merge both if you prefer but I thought it might be easier to review if I kept both separated

Your feedback whenever you have time will be appreciated and I appreciate the time you take to do that so just wanted to say that there is no urgency ;)

alexbelgium commented 3 months ago

Thanks for the review, corrected now