Feat : proposal to standardize behavior of click on Com_Name and Sci_Name

Nachtzuster / BirdNET-Pi

A realtime acoustic bird classification system for the Raspberry Pi 5, 4B 3B+ 0W2 and more. Built on the TFLite version of BirdNET.

https://birdnetpi.com

Other

133 stars 20 forks source link

Feat : proposal to standardize behavior of click on Com_Name and Sci_Name #116

Closed alexbelgium closed 3 months ago

alexbelgium commented 3 months ago

This PR harmonizes the behavior of what happens when clicking com_name or sci_name on different pages, and makes more explicit the external links by using icons :

Click on com_name = open species page
Click on sci_name is disabled
There is 4 icons now :
- If not in kiosk mode : (i) open info_site ; (w) open wikipedia
- For both mode : open minigraph, open spectrogram page
The link to open spectrogram appears both for mobile and desktop, I don't see why it was mobile only before

Requires : #113

Before/after :

Last species detected
5 latest overview
Todays's species :
Recordings :
Stats :

alexbelgium commented 3 months ago

Clarified the pictures. Main remaning element : should minigraph be added to the Recordings as well

Nachtzuster commented 3 months ago

nice!

Nachtzuster commented 3 months ago

I guess we want the scientific name in italics here too

Nachtzuster commented 3 months ago

Clarified the pictures. Main remaning element : should minigraph be added to the Recordings as well

Probably not: in my mind, recordings is more a historic data browser, while the other pages are more a 'what's going on' thing

alexbelgium commented 3 months ago

Thanks, added. Agree with the minigraphs - and it would request a code refactor probably (move minigraphs to common.php) to make it more transversal, so let's keep as it is ;-)

Nachtzuster commented 3 months ago

@alexbelgium I guess this one is ready for merging too, right? Just one question: where are the icons coming from? ie. are 'we' allowed to use them?

(my counting is off-by-one, no make that two)

alexbelgium commented 3 months ago

;-) Hi, ready for merge indeed I've been using it for the past week and did not find issues that I have not corrected yet

Regarding icons : the wikipedia one comes from their website under CC (https://be.m.wikimedia.org/wiki/File:Tango_style_Wikipedia_Icon.svg) ; and the information one from wikipedia without any constraints (https://commons.wikimedia.org/wiki/File:Information-icon.svg)

Btw I took those as they were convenient and easily readable but we could adapt their style if you preferred (all rounds or all squarish)

Nachtzuster commented 3 months ago

Thanks @alexbelgium