search

Nachtzuster / BirdNET-Pi

A realtime acoustic bird classification system for the Raspberry Pi 5, 4B 3B+ 0W2 and more. Built on the TFLite version of BirdNET.
https://birdnetpi.com
Other
172 stars 24 forks source link

PRs I think are ready to accept. #201

Closed lloydbayley closed 1 month ago

lloydbayley commented 1 month ago

I've been testing out the following PR's and they seem to be stable. Any other opinions?

198 195 194 190 166

Just trying to triage things a little as they seem to be piling up.

If all in agreement, perhaps @Nachtzuster might look at merging them?

Emmo213 commented 1 month ago

I know this was just closed but for PRs which have been open for awhile it'd be nice to have feedback on if something is wrong with them or if they're just not wanted. Leaving them open with no feedback isn't helpful to the requestor.

lloydbayley commented 1 month ago

I only closed it because things had been done with no indication and my issue was adding to the clutter. I guess I've upset the apple cart by asking for action. Again. I can re-open it if you like or you can start your own since quite a few were yours.

Emmo213 commented 1 month ago

My comment wasn't geared towards you, but just in general. Like I have a few PRs opened but aren't merged and I don't know why. Is there something wrong with the code (and not just "I would have done it differently") or are the changes unwanted? The one, the wiki link, I didn't need as an enhancement but somebody requested it and I thought "that's an easy enhancement I can make for somebody" but it hasn't been merged. I can close it but then we should tell the person that requested it that it's not going to happen.

lloydbayley commented 1 month ago

Nono, I realise that it wasn't geared toward me. I, too, was hoping for some feedback but alas. I'll open this again to see.

lloydbayley commented 1 month ago

@alexbelgium, Have you any opinions on those PR's? Would be interested in your thoughts even though they have been merged.

alexbelgium commented 1 month ago

My comment wasn't geared towards you, but just in general. Like I have a few PRs opened but aren't merged and I don't know why. Is there something wrong with the code (and not just "I would have done it differently") or are the changes unwanted? The one, the wiki link, I didn't need as an enhancement but somebody requested it and I thought "that's an easy enhancement I can make for somebody" but it hasn't been merged. I can close it but then we should tell the person that requested it that it's not going to happen.

I do remember Nachtzuster saying somewhere that he is quite busy and has little time for the moment so only merges things that don't need in depth review.

The key element is that, as for any github dev, it is all done on top of busy lives and I understand if he has other priorities in his life to look at for the moment. Especially as I saw from his past interactions that he puts a point to ensure code stays lean & efficient - so actually I prefer for him indeed to take the time that he needs and hopefully merge it at some point when he'll have time.

Let's not forget that anyway we can merge locally on our systems PRs so we can still benefit personnaly even if it is not merged in the main repo !

alexbelgium commented 1 month ago

@alexbelgium, Have you any opinions on those PR's? Would be interested in your thoughts even though they have been merged.

Not yet merged :

Merged :

lloydbayley commented 1 month ago

Right. I'll stay out of it. Just wanted to make sure that the repo wasn't dying as there is no feedback when there is action.

alexbelgium commented 1 month ago

Well I didn't really want to push back, but as a repo maintainer myself I empathise with the complexity of managing expectations while also having lots of things in parallel

But I'm sure your support is appreciated, for example your post here led to the merging of most of the PR linked

lloydbayley commented 1 month ago

Closed as it's pointless leaving it open because there isn't likely to be anything constructive out of it by the looks of things. I've unsubscribed from the thread. I'm sorry I pushed the issue in the first place. Not apologetic, just sorry I started it to cause the drama...