Closed alexbelgium closed 1 month ago
Ho Ho!!! Nice one! Just tested on my dev server as works as expected. It's actually quite a handy addition being a filter that only shows the string you want no matter where they are in the sci name or common name!
Thanks very much for the feedback! Have you tested the bird detection change other PR btw? Always interested to gather feedbacks if useful or simply works :) There should be no risks in theory as it uses the same safeguards (of max 1 sqlite line modification) as the deletion feature :)
Thanks very much for the feedback! Have you tested the bird detection change other PR btw? Always interested to gather feedbacks if useful or simply works :) There should be no risks in theory as it uses the same safeguards (of max 1 sqlite line modification) as the deletion feature :)
Not as yet, I can see that with your new-found enthusiasm, I'm going to have to set up a development instance with a live mic for testing! I took the other one apart when development ceased on the original repo! Hehe! Will work on that and then I can test things that have to do with detections properly!
well I don't intend to do that many changes... it's mostly webui elements based on what I perceive as what could improve an already great app to solve some minor elements... well if you have the opportunity it will sure be welcome but otherwise don't take too much time on that I'm running it 24/24 on my main rpi and will anyway see if something breaks ;-)
Ahh god, I can run up a test Pi in 10mins. I have a couple of 4's lying around snoozing that could be put to better use! :)
Alex, I tried your PR today and unfortunately, I had the following. There's no way to get out of it either!
Love the bird icon BTW!
Oh no, in theory you could either click on the blank part of the page or click escape, could you please try?
What is your test system? I had tested windows with edge, and ios with safari
I see also that the list is blank which is also an abnormality
Was using Firefox on Mac.
Just tried on iOS as well with Safari. Same thing. ☹ Clicking on blank space and Esc don’t work. That was the first thing I tried.
I must admit, I haven’t looked at the code. Is it supposed to list all birds as a possible replacement?
Mmh perhaps there was a dependency to a specificity of my addon that I missed. I'll double check thanks for the check!
Happy to help.
To be sure : this feedback pertains to PR https://github.com/Nachtzuster/BirdNET-Pi/pull/62 but this one works, right?
Ahh God, I'm so sorry...This was all meant to be in 62. How do we do that? Delete all and replay there? Bugger!
Let's keep it as the fact that this PR was working in https://github.com/Nachtzuster/BirdNET-Pi/pull/69#issuecomment-2119288399 and we'll continue the discussion in 62 ;) i'll test on my side why this PR would work and not the other
Thanks very much for the review ; I've implemented your updates
Issue : on mobile, the user input box to make easier to go to a specie doesn't work as there is no "enter touch". This means that people have to manually find the specie to include or exclude, which is cumbersome as it starts with the scientific name
Proposed solution : use the input box for filtering of the list instead. It works on both browser (tested on windows with edge) and mobile (tested on ios with safari and edge)
I've used the same logic of filtering for my other PR which proposes to convert an identified specie to another (and correct database + files storage location)
Of course, it's as you want, perhaps it is a bit specific based on my own usage of the app :-)