search

Nachtzuster / BirdNET-Pi

A realtime acoustic bird classification system for the Raspberry Pi 5, 4B 3B+ 0W2 and more. Built on the TFLite version of BirdNET.
https://birdnetpi.com
Other
133 stars 20 forks source link

Adminer iframe ? #78

Closed alexbelgium closed 4 months ago

alexbelgium commented 4 months ago

Hi,

Everything uses iframe in BirdNET-Pi, is there a specific reason why adminer would not ? I just changed the X-Frame-Options from Deny to Sameorigin and it seemed to work on my system?

It seems the downside is that we lose location when refreshing the page ; but database modification should not occur frequently so it should not be such an issue. For these specific cases, I've added a link to open adminer in a new page if needed

alexbelgium commented 4 months ago

Btw it seems the file encoding was not UTF8 and it was converted automatically when updating from github online, not sure it is an issue or not

Nachtzuster commented 4 months ago

Everything uses iframe in BirdNET-Pi, is there a specific reason why adminer would not ?

I have no idea :smile: Most likely it was just the path of least resistance

I'm fine with having it in an iframe, makes everything consistent. :+1:

I would like the files keep the original encoding to keep the diffs sane, could you fix that?

alexbelgium commented 4 months ago

For info, here is the github editor warning specifically for the adminer*.php files : We’ve detected the file encoding as ISO-8859-1. When you commit changes we will transcode it to UTF-8.

Should be good! Thanks