Nachtzuster / BirdNET-Pi

A realtime acoustic bird classification system for the Raspberry Pi 5, 4B 3B+ 0W2 and more. Built on the TFLite version of BirdNET.
https://birdnetpi.com
Other
89 stars 18 forks source link

Changing bird species gives error #81

Closed Hiemstra87 closed 1 month ago

Hiemstra87 commented 1 month ago

PLEASE READ THE DOCUMENTATION BEFORE SUBMITTING AN ISSUE

Describe the bug When i try to change the species it throws an error. (See screenshot). "The first argument should be a starting with the common name of the bird and finish with mp3!, Instead, it is : Porseleinhoen***.wav
" It does not change the species of the recording.

To Reproduce Go to recordings -> by species -> -bird- Tap bird icon Choose new species Confirm the "are you sure" Error Steps to reproduce the behavior:

Expected behavior no error and change of species.

Screenshots Screenshot_20240601-213604

Additional context actions from a Google Pixel phone on Chrome browser: version 125.0.6422.146 com.android.chrome

Your build Birdnet-PI build on RasPI 5, additional install of Cloudflared.

Code or log snippets "The first argument should be a starting with the common name of the bird and finish with mp3!, Instead, it is : Porseleinhoen***.wav
"

alexbelgium commented 1 month ago

Thanks for reporting! Indeed i considered only files saved as .mp3, I didn't knew it was possible for other formats. I'll make an update proposal to the code

Edit : OK I see there is MANY formats for extracted files. I'll modify the code to accept *.* instead of *.mp3 ; at least this will make sure that an url with an extension is passed

Hiemstra87 commented 1 month ago

Wow that's a quick reply! Thanks!

alexbelgium commented 1 month ago

Well there was a lack of goals in the Champions league final so I was a bit idle - this has changed however since ;)

Hiemstra87 commented 1 month ago

Yeah, bit of a disappointment Dortmund didn't win though

alexbelgium commented 1 month ago

Indeed... Rm has enough trophies on their shelves... And I had the luxury of being perfectly neutral in this final

lloydbayley commented 1 month ago

Nice bug-squash! I must admit, I, too, had forgotten about the possibility of changing format. I never really occurred to me to alter it but I guess when you have ffmpeg at your disposal, the world is your oyster! :) Bonne Chance & Viel Glück to you both!

Hiemstra87 commented 1 month ago

Nice quick fix, just tested it, works like a charm. You're making a lot of people happy with this feature.

lloydbayley commented 1 month ago

He can't help it....He's a people-pleaser... :) (I don't know how to do an emoticon)