Closed OliNau closed 3 months ago
Tested this on my dev installation and it works for me. Nice one!
Mmm, additional testing shows this only seems to work when pressing the 'testing' button, but not with actual detections. So it should not be merged at the moment, I think.
Okay, the python parts is also updated, so it should work now.
Nice.
I do find the maskedlistenurl
name a bit strange.
suggestions: prettyurl or friendlyurl ... ?
I chose the term because it's consistent with how it's referred to in Discord docs and other places that use Markdown. They call it 'masked links'.
However, the name isn't a big deal to me, so feel free to pick a name you prefer! :)
@Nachtzuster, What do you think about markdownurl
?
Fair point, well-made. I hadn't tested it in 'live' mode. I'm sorry about that. Perhaps I shouldn't be replying to issues.
@lloydbayley, oh no, I appreciate your feedback. It's just a little weird that the exact same system is implemented both in PHP and in Python, with the former only activating when you push the test button, while the latter works with actual detections.
I know, I keep forgetting the lack of logic in the code. I'm very sorry, I should have checked more.
@OliNau I've been testing this: hiding the url does not work for eg. email and telegram. Not sure if it is worth adding it only works with Discord
It only works for services that support Markdown. Other than Discord also Slack, Mattermost (and some more services) support this.
Because especially Discord seems to be a very popular service for these notifications, I'm still inclined to add it, but it's of course your call to make.
Op vr 7 jun 2024 10:03 schreef Nachtzuster @.***>:
@OliNau https://github.com/OliNau I've been testing this: hiding the url does not work for eg. email and telegram. Not sure if it is worth adding it only works with Discord
— Reply to this email directly, view it on GitHub https://github.com/Nachtzuster/BirdNET-Pi/pull/88#issuecomment-2154308660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AETUG5FXJDLC5HWQKH2SQDLZGFSNZAVCNFSM6AAAAABIZQHEDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJUGMYDQNRWGA . You are receiving this because you were mentioned.Message ID: @.***>
@OliNau
ok, understood.
About the naming: could you switch to friendlyurl
?
@lloydbayley an extra pair of eyes never hurts, thanks for the support.
Well, thank you. And there I was thinking you would rather not have me here.
Changes made. If you have time, feel free to test it @lloydbayley :)
Added $maskedlistenurl as an option for apprise notifications.
Tries to close #80