Nadrieril / dhall-rust

Maintainable configuration files, for Rust users
Other
303 stars 27 forks source link

Incremental builds do not work with this crate #162

Closed bkase closed 4 years ago

bkase commented 4 years ago

Thanks for this project!

I've noticed a somewhat significant issue when working with applications that depend on this crate -- incremental builds do not work.

To repro:

$ mkdir dhall-repro && cd dhall-repro
$ cargo init --application

Cargo.toml:

[package]
name = "dhall-repro"
version = "0.1.0"
edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
dhall = "0.5.1"

src/main.rs:

extern crate dhall;

fn main() {
    println!("Hello, world!");
}

Then, cargo build rebuilds dhall at every invocation even though the crate is not updated. I have not noticed this behavior with any other crates.

If it is helpful, I am using nightly rust.

Nadrieril commented 4 years ago

Yes I've recently noticed the same thing ! It's super annoying. You're lucky, I also just found a fix for this. Let me just make a release and you'll have it

Nadrieril commented 4 years ago

Here you go, version 0.5.2 should fix that. Let me know if that works for you too

bkase commented 4 years ago

Thank you!

Nadrieril commented 4 years ago

Has it solved the problem for you then ?

rlecomte commented 4 years ago

It solve the problem on my side