search

Nadrieril / dhall-rust

Maintainable configuration files, for Rust users
Other
306 stars 27 forks source link

Implement With with no desugar #193

Closed basile-henry closed 4 years ago

basile-henry commented 4 years ago

Part of #180

This would have probably been simpler to implement with recursion, but I got there in the end :sweat_smile:

Nadrieril commented 4 years ago

Nice, this wasn't a straightforward feature to implement!

Nadrieril commented 4 years ago

Code looks good, except for just the thing about the recordtype's type. I'm glad you went iterative, I fear the recursive version would have been harder to follow. The rest is nitpicks :)

Nadrieril commented 4 years ago

Thanks!