search

Nadrieril / dhall-rust

Maintainable configuration files, for Rust users
Other
303 stars 27 forks source link

If can return a type #202

Closed basile-henry closed 3 years ago

basile-henry commented 3 years ago

Implements https://github.com/dhall-lang/dhall-lang/pull/1090

And I believe this is all we need to be compliant with the upcoming standard v20.0.0: https://github.com/dhall-lang/dhall-lang/pull/1116 :smile:

Nadrieril commented 3 years ago

Did you get annoyed at direnv telling you to allow it in this folder? ^^ Looks good, and that means v20 won't need to be a breaking change :)

basile-henry commented 3 years ago

Well, I started using direnv (I would manually open a nix-shell before). And I don't want to accidentally commit its state directory.

Admittedly it probably wasn't the right PR to do this in 😅

Nadrieril commented 3 years ago

Oh, I thought you gitignored .envrc sorry. I don't have a .direnv state directory, I'm surprised you do

basile-henry commented 3 years ago

Oh, I think it's because I use https://github.com/nix-community/nix-direnv Since you also use nix, maybe you should check it out 😄

Nadrieril commented 3 years ago

I use lorri, which I prefer because it builds the environments in the background. Also you can apparently move the .direnv out of the project directory: https://github.com/nix-community/nix-direnv#storing-direnv-outside-the-project-directory