Nadrieril / dhall-rust

Maintainable configuration files, for Rust users
Other
303 stars 27 forks source link

`#[derive(StaticType)]` triggers the `redundant_semicolons` warning #216

Closed qryxip closed 3 years ago

qryxip commented 3 years ago
#![allow(dead_code)]

use serde_dhall::StaticType;

#[derive(StaticType)]
struct Struct {
    param: String,
}
❯ cargo clippy
warning: unnecessary trailing semicolon
 --> src/main.rs:8:16
  |
8 |         param: String,
  |                ^^^^^^ help: remove this semicolon
  |
  = note: `#[warn(redundant_semicolons)]` on by default

warning: 1 warning emitted

    Finished dev [unoptimized + debuginfo] target(s) in 0.05s
❯ rustc --version
rustc 1.51.0 (2fd73fabe 2021-03-23)
❯ rustc -W help | rg redundant-semicolons | head -n1
                                       redundant-semicolons  warn     detects unnecessary trailing semicolons

https://github.com/Nadrieril/dhall-rust/blob/846c14f92bda2fb3e68c3debf940414628013574/dhall_proc_macros/src/derive.rs#L150-L154

Nadrieril commented 3 years ago

Fixed in https://github.com/Nadrieril/dhall-rust/pull/215

Nadrieril commented 3 years ago

The fix is in v0.10.1