NadyaNayme / BetterBuffsBar

Track what matters
MIT License
6 stars 4 forks source link

AD icon with magic tank armor bonus not tracked #1

Closed filipagh closed 8 months ago

filipagh commented 11 months ago

image

animate dead is not tracked with BetterBuffs but alt1 can track it

it happend when you have magic tank armor then icon of buff change without magic tank armor AD is tracked OK

filipagh commented 11 months ago

i suggest change image compare threshold to 60 i test 70 but it fail sometimes

NadyaNayme commented 11 months ago

I'll do some testing actually using it in combat so that I get a proper (arg) for it which will cause the thresholds to change a bit. AD has an issue with lower thresholds in that it would have lots of false positives so I have to dial it in as close as possible.

Also AFK Warden does sometimes lie. It will detect and show the buffs properly when selecting a buff to watch but if you tell it to watch the buff it will fail to actually track it properly. But I do suspect that it is generally more accurate if anything because Skillbert better knows what he is doing. :P

Thanks for the report though. I'll test it out later today.

Horusxav commented 8 months ago

Hey! So did you guys find a solution to this issue? Dealing with this too atm when wearing tank mage armour

filipagh commented 8 months ago

@Horusxav i tweak threshold as workaround for this issue, you can use my updated app

alt1://addapp/https://filipagh.github.io/BetterBuffsBar-AD-workaround/dist/appconfig.json

Horusxav commented 8 months ago

@filipagh Thank you so much amazing :))

filipagh commented 8 months ago

@Horusxav does my fix work for you ?

Horusxav commented 8 months ago

@filipagh yep it works perfectly thanks alot :) havent had any issue

NadyaNayme commented 8 months ago

I've accepted @filipagh 's PR with the lowered threshold as well - just so you can keep using BBB and receiving future updates rather than having to use a fork to fix an issue with a singular buff.