NadyaNayme / BetterBuffsBar

Track what matters
MIT License
7 stars 4 forks source link

Lower AnimateDeadBuff threshold detection #9

Closed filipagh closed 10 months ago

filipagh commented 10 months ago

1

NadyaNayme commented 10 months ago

The threshold isn't the problem here. It's that Alt1 can't read any buffs that split onto two lines due to a bug.

10 (10) is fine and Alt1 can parse the timer.

If a buff looks like:

10
(10)

the buff won't be read and the time will read as 0 which means inactive.

Previously Alt1 could read the latter but not the former due to a bug in it parsing the ( character - resulting in 10 (10) being read as time: 10, arg: 0 instead of time: 10, arg: 10. Skillbert fixed that for me but by doing so it broke Alt1's ability to parse the latter as time: 10, arg: 10 and now it parses it as time: 0, arg: 0.

This affects non-beta BOLG tracking, incense tracking w/ certain time+stack combinations, animate dead w/ certain time+armor value combinations, and any other buffs that sometimes split the (args) onto a second line.