NadyaNayme / TidyChat

A better chat experience, with fewer redundant messages and system spam.
GNU Affero General Public License v3.0
18 stars 11 forks source link

[FILTER] Linkshell membership messages #63

Closed alercah closed 1 month ago

alercah commented 1 year ago

Filter Request

What is the exact in-game message? A screenshot is fine but copy/paste is preferred.

Player Name invites you to join “Parade of Homes.” Player Name has joined “Parade of Homes.” You join “Parade of Homes.” You leave “Parade of Homes.”

and probably one for another person leaving but I don't know it.

When does this message happen?

When a player joins a (CW)LS.

Why is it important to see this message?

There's otherwise no way to notice that someone else joined or left. For invites, you might miss the popup text.

NadyaNayme commented 1 year ago

I'm going to make the "party" filters less strict so that the joins/leaves/invites aren't restricted by the inclusion of the word "party". This should hopefully fix it to work for FC's and (CW)LS's since the "invites you to", "has joined", "you join", and "you leave", and " has left" messages are all pretty generic and I'm not sure will introduce any false positives if I loosen the reigns a bit.

Mostly because I don't want to create triplets of what are essentially the same exact filter - and I don't think many people intend to disable these social messages (and anyone who does probably wants to disable all of them anyway).

Thanks for the report! And sorry it took so long for me to come back and respond.

NadyaNayme commented 1 year ago

So I'm going to leave this open because I think I'm going to have to do this the "proper" way - but I'm also lazy. I've tried the lazy way which should hopefully work without too many false positives.

The false positives is why I'm leaving this open - as the reigns may be too loose now.

Should be included in v1.2.3 once I push it out

NadyaNayme commented 1 month ago

I don't even remember what I'm supposed to be checking for but seeing as nobody has been complaining I think whatever I did back in Jan 2023 worked.