search

NadyaNayme / TidyChat

A better chat experience, with fewer redundant messages and system spam.
GNU Affero General Public License v3.0
17 stars 11 forks source link

[FILTER] Add Mooch filter in fishing #80

Open cc12138030 opened 5 months ago

cc12138030 commented 5 months ago

Filter Request

What is the exact in-game message? A screenshot is fine but copy/paste is preferred. "You recast your line with the fish still hooked."

When does this message happen? After casting with a moochable fish.

Why is it important to see this message? Certain plugins require this line to appear for their functionality, especially for timing purposes.

I have been completely unable to whitelist this line manually. No matter what I do it remains filtered.

cc12138030 commented 5 months ago

Or this line could also just be included in the already available option "Show name of fishing hole when line is cast".

NadyaNayme commented 5 months ago

Was this related to or fixed by https://github.com/Ottermandias/GatherBuddy/pull/220 by any chance?

I can add the filter but that it hasn't been an issue until very recently makes me think it was related to the recent changes from ChatMessage --> ChatMessageHandled.

cc12138030 commented 5 months ago

After reading that post that does seem to be the issue that is happening, but it doesn't look like there has been an update on GatherBuddy's end yet. There may be one in the works, but I'm not sure. Either way, it seems like the root cause has been determined, so you can proceed or ignore this in whichever direction you see fit.

NadyaNayme commented 5 months ago

It should be included in the next release - although I'm not 100% sure if it is a fix or not as I'm a bit removed from Dalamud developments as of the past year or so.

For now I ask you either disable the Gathering filter, add a custom filter for the Gathering channel of /recast your line with the fish/ (with the /'s so it gets parsed as a Regex) which should work.

If the next Gatherbuddy release doesn't fix the issue I'll absolutely go in and add the new filter for it.

cc12138030 commented 5 months ago

Unfortunately that custom filter doesn't work, not sure why. I tried to set up custom filters before, including a regex version. Either way, disabling the main Gathering filter works fine, and multiple people are aware of this new chat message hook, so it'll get sorted out eventually.