Close the sockets so that the OS doesn't get confused

Naereen / uLogMe

:bar_chart: :chart_with_upwards_trend: Automatically collect and visualize usage statistics on Ubuntu, with :musical_keyboard: key frequencies and :computer: window titles →

https://Naereen.GitHub.io/uLogMe/

MIT License

67 stars 14 forks source link

Close the sockets so that the OS doesn't get confused #6

Closed Burrito-Bazooka closed 8 years ago

Burrito-Bazooka commented 8 years ago

Credit to @blackdaemon: https://github.com/blackdaemon/ulogme/commit/85598fa5763d2c626af859cae6b03a8cee17a3d0 . I find these by looking at this graph: https://github.com/karpathy/ulogme/network

Doing this means the OS won't think the port is still occupied for a minute.

Let me know if submitting suggestions in issues is better for you than submitting pull requests.

Naereen commented 8 years ago

That's smart, thanks. Done, 77f4ae7.

I am thankful for the PR as well as the issues! I usually prefer to modify the code myself (as it gives me more ideas), so I guess PR are the best, but don't feel bad if if close it (after merging your suggestions manually and a little bit differently).