search

Naezr / ShyFox

A very shy little theme that hides the entire browser interface in the window border
Mozilla Public License 2.0
1.71k stars 31 forks source link

Background for some menus is transparent #51

Closed minec-aw closed 5 months ago

minec-aw commented 5 months ago

Haven't seen anybody else comment about this, but I found some menus to have no background. pictures shown below: image

To explain the picture: the find panel at the bottom has a transparent background, the toolbar to the right has a transparent background (also I cannot put stuff in the toolbar, hence why there is only two items) But the right click menu does have a background.

Running KDE plasma 6.1 on wayland using NixOS

minec-aw commented 5 months ago

I have found the issue. Inside of shy-variables.css: image tb-col is transparent. Me setting the value to rgba(0,255,0,0.5); made an ugly green that I can see. This means that toolbar-bgcolor is also transparent.

image

Naezr commented 5 months ago

If you look at the changelog, one of the most recent changes was a redesign of the README. I decided to make it more tidy before posting it to r/unixporn.

Before that, the Adaptive Tab Bar Color extension was a must-have. If you look in the recommended Adaptive Tab Bar Color settings below in the README, I mentioned there that the panels can be transparent for some reasons.

All these problems with transparent panels come from the lack of Adaptive Tab Bar Color. It's my mistake that I should have not tested the theme without it. As a temporary solution install it. And I'll have to work on making the theme work without it.

Naezr commented 5 months ago

It was a hasty explanation. There are other possibilities. Are you using System Theme - auto?

Naezr commented 5 months ago

Auto theme looks broken for me too image But just dark or light working fine image

minec-aw commented 5 months ago

It seems like I was using system theme, and it fixed another issue but not the menu issue. Making the toolbar background color different from the tab bar background color in adaptive tab bar color plugin did fix it. Thank you

Naezr commented 5 months ago

I'll leave this issue open, as I need to figure out why your panels are transparent without Adaptive Tab Bar Color. I want to leave the possibility of choice in terms of colors.

minec-aw commented 5 months ago

I use Adaptive Tab Bar Color, sorry if that wasn't clear. However, I did not use it inside of private windows, and my menu was transparent. Turns out that system theme auto was the cause for that issue, and my menus being transparent were fixed with changing the adaptive tab bar color settings