search

Naezr / ShyFox

A very shy little theme that hides the entire browser interface in the window border
Mozilla Public License 2.0
1.43k stars 22 forks source link

Sidebery closes after dragging a tab #64

Closed konfitti closed 2 months ago

konfitti commented 3 months ago

https://github.com/Naezr/ShyFox/assets/69910686/dcdd9a97-e95e-48ea-bc3c-b26889058986

Naezr commented 3 months ago

Known issue. I don't know how to fix it. For some reason on Linux the cursor holding something doesn't activate the :hover css selector. On Windows it works as it should

Naezr commented 3 months ago

Запись экрана от 2024-06-27 14-28-54.webm

SourCreamKun commented 3 months ago

I think the issue was when you separate a tab to a new window sidebery closes, in windows it closes too. It also is closed when you open a new window from firefox shortcut on taskbar

Naezr commented 3 months ago

The fact is that the logic of this is different on Windows and Linux, although the css code is the same everywhere.

Duder963 commented 3 months ago

That's odd. I've been using this on Arch Linux for a few days now and sidebery drag and drop was working just fine with the latest version until I reinstalled it from scratch after the theme bugged out on me, and now I'm experiencing this issue.

Duder963 commented 3 months ago

Found a partial fix from this bug report. Setting widget.gtk.ignore-bogus-leave-notify=1 stops sidebery from closing on dragging a tab. However sidebery will not close upon leaving the hover area while dragging, and another window's sidebar will not expand. I still have no explanation for why it was working just fine for me a few days ago. For reference I'm using Hyprland

Naezr commented 3 months ago

Setting widget.gtk.ignore-bogus-leave-notify=1 stops sidebery from closing on dragging a tab.

It works and it really helps. When you change this setting, the behavior becomes the same as on Windows. I'll add it to user.js

However sidebery will not close upon leaving the hover area while dragging, and another window's sidebar will not expand.

Yes, the behavior is the same on Windows, I checked it out

Duder963 commented 3 months ago

Did some more sleuthing. This regression(?) occurred between Hyprland 0.41.1 and 0.41.2. You say sidebery does not retract upon leaving its hover area on Windows, does this mean that is intended behavior? Because on 0.41.1 the sidebar does hover and unhover while dragging, and I can, for instance, move tabs between two windows

Naezr commented 3 months ago

I would like to get behavior like yours, so that the cursor holding the tab just activates :hover as usual. I don't know if there is an intended behavior here. No one intended Firefox to work this way. It's possible that the fact that sidebar stays popped up on Windows (and Linux when you change that setting) is a bug.