macOS issues

[LiquidLemon]

Hey, I just wanted to start by saying great work. This theme looks amazing and I didn't even know something like this was possible in Firefox (we definitely need more themes like this). I tried running this theme on macOS and I found a few issues. I don't know if you're at all interested in including compatibility but I would be grateful if you have any pointers how to approach fixing the issues I found.

Address bar

It's kind of hard to explain but when I click the address bar the cursor is stuck in highlight mode. When I move it (without pressing any mouse buttons) the address gets highlighted from the start of the URL. This doesn't happen on the first time I click it after launching the browser. Selecting the address via shortcut works as expected though. I can provide a video if you want.

Sidebery

Sidebery doesn't really work as expected :(

Overlapping window controls

This is pretty much expected since it wasn't accounted for, though I'm a little surprised to see that the sidebar stretches all the way to the top of the window.

Pinned tabs

The styling doesn't seem to work at all:

Touchpad/trackpad

I found out that switching tab panels with horizontal scroll is completely unusable on touchpad. I don't actually know if this is macOS exclusive. You can technically try to tune it (https://github.com/mbnuqw/sidebery/issues/1252) but I haven't been able to get it to work reliably. It's pretty confusing and I didn't even know that it's a feature so maybe you could mention it in the README to save others some confusion (unless this really is just a macOS issue).

---

Like I said I'd appreciate any help with fixing these issues. I don't have any experience in modifying browser styles but if you point me in a direction I'd be happy to try troubleshooting it on my own.

[LiquidLemon]

I noticed you had bookmarks next to the buttons in screenshot so I enabled the bookmarks toolbar (I never use bookmarks) and now it works (the margins are a bit ugly but I suppose nothing can be done about that).

[LiquidLemon]

I resolved the lack of styling in Sidebery - I was using a symlink and looks like Firefox is happy to load userChrome.css from a symlink but not userContent.css.

[Naezr]

When I move it (without pressing any mouse buttons) the address gets highlighted from the start of the URL.

I get exactly the same behavior in situations where the urlbar goes to full screen mode and there is already some text in it

https://github.com/Naezr/ShyFox/issues/66

This is pretty much expected since it wasn't accounted for, though I'm a little surprised to see that the sidebar stretches all the way to the top of the window.

Intended behavior. Use Sidebery settings to leave empty space for buttons.

Or turn on the bookmark bar. You can remove the bookmarks from there and put some buttons or something like that

I was using a symlink

I use symlinks too. I use them to synchronize files with GitHub in semi-automatic mode. And they didn't work for me the first time. First you have to put the real files in and run Firefox once. After that you can replace the files with symlinks.

I don't know if you're at all interested in including compatibility

I am interested in this and am testing the theme on Windows, even though I use Linux myself. However, I don't have a Mac and can't test the theme there

I don't have any experience in modifying browser styles but if you point me in a direction I'd be happy to try troubleshooting it on my own.

https://www.reddit.com/r/FirefoxCSS/wiki/index/tutorials/

[Naezr]

@LiquidLemon

Right now in the nightly branch I'm testing and adding icons to the context menu. On Linux everything was fine initially, but for Windows I had to make some adjustments so that the text doesn't overlap the icons. I'd like to see how this behaves on macOS. If you don't mind, could you please test this for me?

[LiquidLemon]

@Naezr sure thing, do you have any reference for how it should look?

[Naezr]

@LiquidLemon Linux: Windows:

[LiquidLemon]

Here's how it looks:

Unfortunately, I had to toggle widget.macos.native-context-menus to get it to show up because by default on macOS Firefox uses native context menus. So without disabling that feature I get just a normal menu: (I imagine the icons need to be passed in some other way and can't just be added in CSS for that)

[Naezr]

As far as I know you can't add icons to all items using the same method as with items from extensions.

The icons of extensions to which I haven't added a custom monochrome icon shifted to the right on Windows as well. Most likely fixable on my end.

Sadly, even by disabling the native system menus the back, forward, reload and bookmark buttons remain text-based. I like the iconic buttons at the top of menus on other systems.

However, overall everything works, so basically it's fine.

edit: Rounded corners don't seem to work properly too. Noticed that now

[LiquidLemon]

Well TBH I think most people won't ever see this, I had to go and look up if there even was a way to disable the native menu.

[Naezr]

It is enough to add a mention in the readme. Anyway I intend to add settings via about:config to turn off context menu icons, floating urlbar, etc. Toggling one more value won't make things harder.

[Naezr]

@LiquidLemon

I've updated the nightly branch.

Expected changes for macOS:

• The corners of the non-native context menu are not rounded, as it is wrapped in the native menu shell.
• Items back, forward, reload and bookmark should get icons
• Icons of extensions with the standard icon should stand exactly on the grid with the monochrome ones.

Note that context menu icons and monochrome extension icons should now be activated via about:config (check README). They are disabled by default

[LiquidLemon]

Looks great (sorry if you saw the previous comment, I need to learn to read before doing things 😅 )

[Naezr]

Re-read my previous message. Icons are now disabled by default. To turn them on you need to write a special value in about:config. These values are specified in the README of the nigtly branch.

[LiquidLemon]

@Naezr yeah, I'm sorry I thought I'd fix that before you had the chance to read it. I feel really silly about missing that.

[Naezr]

I feel like I'm too fast, as I read notifications almost immediately after they come in. Sometimes I even wait a bit on purpose.

Thank you very much for your help. Hopefully you will be able to test some things on macOS next.

[LiquidLemon]

I'm happy to help, I'm enjoying the theme a lot. I might be a little slow responding to issues at times though because I tend to get swamped with notifications from a work organization.