Naezr / ShyFox

A very shy little theme that hides the entire browser interface in the window border
Mozilla Public License 2.0
1.32k stars 19 forks source link

Dragging tab to create new window - new window has sidebery closed and "open sidebar" error message #92

Open nirurin opened 1 month ago

nirurin commented 1 month ago

Dragging a tab out of the tab bar causes a new window to open, which is standard sidebery behaviour. The problem is that when it happens, the new window has a blank sidebar panel with the red "open sidebar" error message showing. In order to get sidebery back, I have to manually toggle sidebery back on.

This is not a sidebery or firefox issue, as I have tested this on other browser instances (without shyfox) as well as on Floorp, and the new tab windows open as normal and sidebery is still open in the new window sidebar.

I have also noticed that after the new windows is made, a new bug appears (which may or may not be related, but I assume it's related). When you hover over a tab, and the popup thumbnail appears, it is no longer the default popup overlay but instead it falls back to the 'popup in window' version which uses a small window frame. And in that window frame, I can see a big red "open sidebar" error message!

Screenshot 2024-07-17 055245

Naezr commented 1 month ago

Dragging a tab out of the tab bar causes a new window to open, which is standard sidebery behaviour. The problem is that when it happens, the new window has a blank sidebar panel with the red "open sidebar" error message showing. In order to get sidebery back, I have to manually toggle sidebery back on.

Maybe issue with your current profile https://support.mozilla.org/en-US/questions/1342740

And in that window frame, I can see a big red "open sidebar" error message!

I don't use such a preview myself, for my system centers all new windows. I don't use previews at all, btw. I will try to make sure that nothing unnecessary is displayed there.

Try to use different preview methods, window mode is experimental изображение

nirurin commented 1 month ago

I don't have it set to window mode, I have it set to popup. Some part of the error event seems to cause popups to stop working so it falls back to using window mode as a backup.

I'll try the profile change though and see what it does. Though I already did a complete firefox wipe (removing all appdata folders) and that didn't seem to fix anything. I'll try though.

On Wed, 17 Jul 2024, 06:16 Naѣzr, @.***> wrote:

Dragging a tab out of the tab bar causes a new window to open, which is standard sidebery behaviour. The problem is that when it happens, the new window has a blank sidebar panel with the red "open sidebar" error message showing. In order to get sidebery back, I have to manually toggle sidebery back on.

Maybe issue with your current profile https://support.mozilla.org/en-US/questions/1342740

And in that window frame, I can see a big red "open sidebar" error message!

I don't use such a preview myself, for my system centers all new windows. I don't use previews at all. I will try to make sure that nothing unnecessary is displayed there.

Try to use different preview methods, window mode is experimental default.png (view on web) https://github.com/user-attachments/assets/979acd33-6667-4220-8902-376f4cee4d3c

— Reply to this email directly, view it on GitHub https://github.com/Naezr/ShyFox/issues/92#issuecomment-2232435927, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4T22KETEY2RHHLJIMRY7LZMX44VAVCNFSM6AAAAABK722QPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSGQZTKOJSG4 . You are receiving this because you authored the thread.Message ID: @.***>

Naezr commented 1 month ago

Popup mode doesn't work very well either. If you hide the sidebar, then when you hover over it, those previews will overlap with the sidebar. For now, I recommend disabling the previews completely.

I may be able to modify the "in sidebar after the tab" mode so that it doesn't change the height of the tab, but create a popup inside the sidebar.

Naezr commented 1 month ago

The short answer is no. “in sidebar after the tab” preview seems almost impossible to style. At least it didn't work for me. And by default they look weird and push all the other tabs down. Window previews work crookedly and are experimental. Previews on the page are overlapped by the sidebar if autohide is enabled.

I haven't used previews before and don't intend to later. I'm more comfortable renaming tabs if I have a lot of them

TetraKarma commented 1 month ago

Maybe issue with your current profile https://support.mozilla.org/en-US/questions/1342740

I tried the fix suggested, but the problem 'open sidebar' still persists. xulstore.json is also recreated after a few moments on firefox startup.

(note, I haven't tried sidebery without shyfox, so I can not confirm which one is causing this behavior)

Naezr commented 1 month ago

Do I understand correctly that you drag a tab from Sidebery to the outside, it opens in a new window and in that window sidebar doesn't open automatically?

I'm not sure if css styles can have any effect on the logic of opening the sidebar. Don't confuse it with toggles, by browser logic the sidebar is always open/active/running.

Try removing the theme. Rename the chrome folder to chrome1 or something like that. See how it behaves that way

TetraKarma commented 1 month ago

The issue occurs when i open a new window or open the tab in a new window (I am running on arch).

Try removing the theme. Rename the chrome folder to chrome1 or something like that. See how it behaves that way

Sidebery doesn't launch automatically for subsequent instances of firefox. Thank you for the suggestion, it seems sidebery doesn't launch automatically on new windows

Naezr commented 1 month ago

How it works for me:

Запись экрана от 2024-07-18 13-08-00.webm

Since ShyFox is not involved in this problem, there is nothing I can do to help

nirurin commented 1 month ago

What version of firefox are you running?

Seems odd that sideberry opens for you, but it doesn't for me or other users. I posted this question on reddit to see if someone might have a fix and people seemed to think its a firefox or sidebery bug (which is valid) but if that was the case you should -also- be having the same behaviour.

That it works for you, means you have something running that fixes the issue.

Edit: I am currently running it on the basic 128 stable release. Are you on beta or nightly?

Edit2: You can see in your example that it opens to the 'open sidebar' red error message, but then it automatically opens up sidebery. For everyone else the sidebery step isn't happening (I'd have to press the manual button to reopen it).

Naezr commented 1 month ago

I'm using the flatpak release of Firefox for Linux. Version 128 at the moment.

I decided to check on my Windows virtual machine and it turns out that there the sidebar really doesn't open in new windows created by drag-n-dropping tab.

After that I decided to try it on a clean profile on my Linux. Here too, the sidebar does not open automatically. Sidebar opens when creating a new window manually, but does not open when drag-n-dropping a tab from Sidebery. That's weird. Maybe there is some old setting in my profile that has changed its default value. I didn't customize anything for it. However, my profile is quite old and has gone through many updates

nirurin commented 1 month ago

I'm using the flatpak release of Firefox for Linux. Version 128 at the moment.

I decided to check on my Windows virtual machine and it turns out that there the sidebar really doesn't open in new windows created by drag-n-dropping tab.

After that I decided to try it on a clean profile on my Linux. Here too, the sidebar does not open automatically. Sidebar opens when creating a new window manually, but does not open when drag-n-dropping a tab from Sidebery. That's weird. Maybe there is some old setting in my profile that has changed its default value. I didn't customize anything for it. However, my profile is quite old and has gone through many updates

Interesting. Would seem to imply that there's a bug introduced in the current css setup somewhere. Hopefully it's possible to narrow it down!

Naezr commented 1 month ago

I'm 99% sure css has nothing to do with it. I also checked without ShyFox, on pure Firefox and Sidebery. Maybe there is some setting for about:config that is responsible for this

nirurin commented 1 month ago

I've had the report up on the sidebery gitthub for a couple days, but I've noticed that the dev there hasn't actually responded to or fixed any bugs for maybe 6 months or more. Seems like there might be a couple contributors trying to keep the lights on but there are pages of unanswered bug reports.

Just for the sake of finding an alternate solution, I'm going to try a different vertical tabs solution, probably 'tree style tabs'. Hopefully it doesnt cause issues with shyfox!

nirurin commented 1 month ago

No immediate issues, but it also has the same behaviour of the sidebar not loading on a new window created via an existing tab. So it seems unlikely that sideberry is the problem either.

karamanliev commented 1 month ago

I too am experiencing the same problem. Removing xulstore.json didn't help. Using latest firefox from the arch linuxrepositories.

themegaxandy commented 2 weeks ago

I use Windows, and this functionality used to work, but now it doesn't work as it should. I don't know if this problem started with an update to Firefox, Sideberry or even ShyFox, it's hard to say. But alternatively, I added an option in Sideberry to move a tab to another new or existing window when right-clicking.

image

ilsubyeega commented 2 weeks ago

Can someone reproduce this issue at 129.0.2 now? it seems to fixed for me.

themegaxandy commented 2 weeks ago

The drag tab to create a new window seems to be fixed after the Firefox update for me as well. The "open sidebar" issue still persists though.

Naezr commented 2 weeks ago

Can someone reproduce this issue at 129.0.2 now? it seems to fixed for me.

Yes, I can confirm it's fixed

Naezr commented 2 weeks ago

The "open sidebar" issue still persists though.

I thought it was some special setting left in my very old Firefox profile. But recently I cleaned up my profile folder and on a newly customized clean profile the sidebar opens by itself.

It's possible that this setting is affecting it: image If so, the solution lay on the surface. If not, I don't know what to do, it's some stupid bug