search

NagRock / ts-mockito

Mocking library for TypeScript
MIT License
974 stars 93 forks source link

Added better verification message #216

Closed mikeporterdev closed 3 years ago

mikeporterdev commented 3 years ago

Duplicated a feature from @johanblumenbergs fork into ts-mockito. Shows a better log message on verify failures to explain the actual calls that were made

Example image

mikeporterdev commented 3 years ago

Johan's fork didn't seem to have a PR open for this feature so I've opened one up. This is a huge addition to the usefulness of this library and I think should be the main priority for new features to be merged in following the discussion in #212

codecov-commenter commented 3 years ago

Codecov Report

Merging #216 (a1be0e5) into master (0b18158) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   93.56%   93.62%   +0.05%     
==========================================
  Files          34       34              
  Lines         653      659       +6     
  Branches       80       80              
==========================================
+ Hits          611      617       +6     
  Misses         29       29              
  Partials       13       13
Impacted Files Coverage Δ
src/MethodStubVerificator.ts 100.00% <100.00%> (ø)
src/utils/MethodCallToStringConverter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b18158...a1be0e5. Read the comment docs.

NagRock commented 3 years ago

@johanblumenberg FYI

mikeporterdev commented 2 years ago

@NagRock this was merged but is it possible to get this deployed, have been waiting for this to roll out for a while