Fix Check_MK B/s vs bit/s detection (Closes: #230)

NagVis / nagvis

Visualization addon for your open source monitoring core

http://nagvis.org/

GNU General Public License v2.0

115 stars 74 forks source link

Fix Check_MK B/s vs bit/s detection (Closes: #230) #247

Closed soeren-gugel closed 4 years ago

soeren-gugel commented 4 years ago

Closes: #230 Check_MK Version 1.6 changed the perfdata, which broke the B/s vs bit/s detection. I added a new detection, which looks for the right format in the check output.

LarsMichelsen commented 4 years ago

Thanks! :)

vpithart commented 4 years ago

Hey @soeren-gugel , I found this change breaking the functionality.

The output.match()[1] construct fails when it does not match.

Please find my fix here. I'm not opening new PR now, as I'd like you to test it against v1.6 data; then please pull it.

-- Vojtech

vpithart commented 4 years ago

Never mind. I have submitted another PR to fix this.

ntokos commented 4 years ago

Edit: never mind, the edit worked after restarting my browser Hello, thank you @vpithart for fixing this. I want to I apply this commit to the code of our installation, while waiting for the new nagvis version, how can I do it? I edited the ElementLine.js and NagVisCompressed.js files but didn't solve the problem. Sorry if its kinda dumb question, I'm a noob in js.