search

NagVis / nagvis

Visualization addon for your open source monitoring core
http://nagvis.org/
GNU General Public License v2.0
115 stars 74 forks source link

Implicit conversions trigger deprecation warnings in PHP 8.1 #335

Closed miken32 closed 1 year ago

miken32 commented 1 year ago

In share/server/core/classes/objects/NagVisStatefulObject.php at lines 265 and 279 a string is implicitly converted to an integer; this needs to be explicitly converted to avoid deprecation warnings.

I was going to submit a PR to resolve this issue; is PHP 5.0 compatibility seriously a requirement? I could almost forgive 5.6, but we're even 5 years out from that being EOL.

miken32 commented 1 year ago

Fixed in #347. Thanks for the response...